Messages in this thread | | | Date | Wed, 20 May 2015 14:00:29 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 3/5] trace-cmd: lookup syscall names in profile |
| |
On Fri, 8 May 2015 15:29:02 -0400 Josef Bacik <jbacik@fb.com> wrote:
> When we profile syscall times we're just given the syscall number, not the name. > This isn't helpful for human beings, so lookup the syscall names when we are > printing out the information. This uses the audit library to get this > information, I'm not married to it, but it seems that any app that does this > mapping has to scrape /usr/include/asm/unistd*.h to pull out the names, so might > as well just use somebody elses work. > > Signed-off-by: Josef Bacik <jbacik@fb.com> > --- > Makefile | 2 +- > trace-profile.c | 19 ++++++++++++++++--- > 2 files changed, 17 insertions(+), 4 deletions(-) > > diff --git a/Makefile b/Makefile > index 63f7e79..402f711 100644 > --- a/Makefile > +++ b/Makefile > @@ -160,7 +160,7 @@ bindir_relative_SQ = $(subst ','\'',$(bindir_relative)) > plugin_dir_SQ = $(subst ','\'',$(plugin_dir)) > python_dir_SQ = $(subst ','\'',$(python_dir)) > > -LIBS = -L. -ltracecmd -ldl > +LIBS = -L. -ltracecmd -ldl -laudit
This fails to compile for me because I don't have a audit-libs-devel installed.
I'll keep this as is, but I'm going to add code to check for this library, and go back to the default raw numbers if it doesn't exist.
-- Steve
| |