lkml.org 
[lkml]   [2015]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/6] i2c-parport: use new parport device model
    On Wed, 20 May 2015 22:44:52 +0530, Sudip Mukherjee wrote:
    > On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
    > > On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
    > > > static struct parport_driver i2c_parport_driver = {
    > > > - .name = "i2c-parport",
    > > > - .attach = i2c_parport_attach,
    > > > - .detach = i2c_parport_detach,
    > > > + .name = "i2c-parport",
    > > > + .match_port = i2c_parport_attach,
    > > > + .detach = i2c_parport_detach,
    > > > + .devmodel = true,
    > >
    > > Minor nit: I prefer to not use tabs but a single space after the struct
    > > member names. Less hazzle in the future and still readable IMO.
    >
    > It was having space originally. I changed that into tab as it was
    > looking good with them as aligned.

    As the driver maintainer, I am fine with both unaligned or tab-aligned.
    Space-aligned as I did originally was not a good idea, I admit.

    --
    Jean Delvare
    SUSE L3 Support


    \
     
     \ /
      Last update: 2015-05-20 20:21    [W:2.555 / U:1.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site