Messages in this thread | | | Date | Wed, 20 May 2015 16:25:48 +0100 | From | Mark Brown <> | Subject | Re: [RFC PATCH 2/2] spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller |
| |
On Wed, May 20, 2015 at 07:55:53AM -0700, Sören Brinkmann wrote: > On Wed, 2015-05-20 at 12:57PM +0530, Ranjit Waghmode wrote:
> > +static u32 zynqmp_gqspi_read(struct zynqmp_qspi *xqspi, u32 offset)
> > +static inline void zynqmp_gqspi_write(struct zynqmp_qspi *xqspi, u32 offset, > > + u32 val)
> why are you wrapping (readl|writel)_relaxed?
It's very common to wrap the lookup from driver data to the MMIO address. [unhandled content-type:application/pgp-signature] | |