Messages in this thread | | | Date | Wed, 20 May 2015 10:28:24 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/4] Revert "perf tools: Fix data_read_offset() file opening" |
| |
Em Wed, May 20, 2015 at 03:34:04PM +0900, Namhyung Kim escreveu: > This reverts commit 9ba6765a979f5f7d3f6456f8c79c66f4aef2d66b. > > The problem will be fixed by later patch in some other way. > > Cc: Adrian Hunter <adrian.hunter@intel.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > Arnaldo, you can ignore this if you drop the Adrian's patch in the tree..
Ok, I did that, now if possible I'd like Adrian's Acked-by for this, ok?
- Arnaldo
> tools/perf/util/dso.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c > index e248f5693a48..1b96c8d18435 100644 > --- a/tools/perf/util/dso.c > +++ b/tools/perf/util/dso.c > @@ -756,7 +756,7 @@ off_t dso__data_size(struct dso *dso, struct machine *machine) > static ssize_t data_read_offset(struct dso *dso, struct machine *machine, > u64 offset, u8 *data, ssize_t size) > { > - if (dso__data_size(dso, machine) < 0) > + if (data_file_size(dso, machine)) > return -1; > > /* Check the offset sanity. */ > -- > 2.4.0
| |