lkml.org 
[lkml]   [2015]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c
On 19/05/15 18:57, Amaury Denoyelle wrote:
> This patch fixes coding style errors reported by checkpatch.pl for
> cb_pcidas64.c, about too long source code lines.
>
> Signed-off-by: Amaury Denoyelle <amaury.denoyelle@gmail.com>
> ---
> drivers/staging/comedi/drivers/cb_pcidas64.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index a94c33c..f1bba2b 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -243,7 +243,8 @@ enum adc_control0_contents {
> ADC_SOFT_GATE_BITS = 0x1, /* software gate */
> ADC_EXT_GATE_BITS = 0x2, /* external digital gate */
> ADC_ANALOG_GATE_BITS = 0x3, /* analog level gate */
> - ADC_GATE_LEVEL_BIT = 0x4, /* level-sensitive gate (for digital) */
> + /* level-sensitive gate (for digital) */
> + ADC_GATE_LEVEL_BIT = 0x4,
> ADC_GATE_POLARITY_BIT = 0x8, /* gate active low */
> ADC_START_TRIG_SOFT_BITS = 0x10,
> ADC_START_TRIG_EXT_BITS = 0x20,
> @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct comedi_device *dev,
> return devpriv->ai_fifo_segment_length;
> }
>
> -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */
> +/*
> + * adjusts the size of hardware fifo (which determines block size for dma xfers)
> + */
> static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
> {
> const struct pcidas64_board *thisboard = dev->board_ptr;
> @@ -1588,7 +1591,9 @@ static inline void warn_external_queue(struct comedi_device *dev)
> "Use internal AI channel queue (channels must be consecutive and use same range/aref)\n");
> }
>
> -/* Their i2c requires a huge delay on setting clock or data high for some reason */
> +/*
> + * their i2c requires a huge delay on setting clock or data high for some reason
> + */
> static const int i2c_high_udelay = 1000;
> static const int i2c_low_udelay = 10;
>
> @@ -1987,7 +1992,8 @@ static unsigned int get_divisor(unsigned int ns, unsigned int flags)
>
> /* utility function that rounds desired timing to an achievable time, and
> * sets cmd members appropriately.
> - * adc paces conversions from master clock by dividing by (x + 3) where x is 24 bit number
> + * adc paces conversions from master clock by dividing by (x + 3) where x is
> + * 24 bit number
> */
> static void check_adc_timing(struct comedi_device *dev, struct comedi_cmd *cmd)
> {
>

Looks good.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-05-20 11:21    [W:0.120 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site