Messages in this thread | | | Date | Wed, 20 May 2015 14:03:40 +0900 | Subject | Re: [RESEND PATCH 2/2] ARM: dts: tegra: Use labels for overriding nodes in Tegra114 boards | From | Krzysztof Kozłowski <> |
| |
2015-05-20 13:05 GMT+09:00 Alexandre Courbot <gnurou@gmail.com>: > On Tue, May 19, 2015 at 8:51 PM, Krzysztof Kozlowski > <k.kozlowski.k@gmail.com> wrote: >> Usage of labels instead of full paths reduces possible mistakes when >> overriding nodes. >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> > > Indentation seems to be off by one tab in the added code (hence the > huge size of this patch ; most lines should not change), can you > check?
It is correct. This change in indentation is an effect of moving nodes out of first bracket ("\ {"). That is the convention.
It us up to you guys if this is worth the effort. For exynos we use label-convention and now I am converting old DTS to it. I think the label-convention is less error-prone when extending or overriding nodes. Also it removes duplicated addresses.
Best regards, Krzysztof
| |