lkml.org 
[lkml]   [2015]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/15] thermal: Add comment explaining test for critical temperature
On 05/13/15 11:52, Sascha Hauer wrote:
> The code testing if a temperature should be emulated or not is
> not obvious. Add a comment explaining why this test is done.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/thermal/thermal_core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 3e0fe55..e204deb 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -435,6 +435,11 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp)
> }
> }
>
> + /*
> + * Only allow emulating a temperature when the real temperature
> + * is below the critical temperature so that the emulation code
> + * cannot hide critical conditions.
> + */
> if (!ret && *temp < crit_temp)
> *temp = tz->emul_temperature;
> }
>

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>



\
 
 \ /
  Last update: 2015-05-20 09:41    [W:0.267 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site