lkml.org 
[lkml]   [2015]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/4] Staging: lustre: sparse lock warning fix
Date
On 2015/05/20, 1:42 PM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:

>In Smatch, it the equivalent warning is turned off by default because
>there are too many false positives, but you can enable it with the
>--spammy flag.
>
>kchecker --spammy drivers/staging/lustre/lustre/ptlrpc/nrs.c
>
>drivers/staging/lustre/lustre/ptlrpc/nrs.c:512 nrs_resource_put_safe()
>warn: 'spin_lock:&nrs->nrs_lock' is sometimes locked here and sometimes
>unlocked.

Would this be happier with something like:

for (i = 0; i < NRS_RES_MAX; i++) {
if (pols[i] == NULL)
continue;


if (nrs == NULL) {
nrs = pols[i]->pol_nrs;
if (likely(nrs != NULL)) /* make sparse happy */
spin_lock(&nrs->nrs_lock);
}
nrs_policy_put_locked(pols[i]);
}

if (nrs != NULL)
spin_unlock(&nrs->nrs_lock);

so that the "if" conditions are the same? The code definitely doesn't
have a bug, because the lock is only locked once when nrs is first set,
and only unlocked if it is set. Or is there a comment to put there that
will quiet the static checker?


Cheers, Andreas
--
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division




\
 
 \ /
  Last update: 2015-05-21 01:21    [W:0.148 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site