lkml.org 
[lkml]   [2015]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: acpi: make ACPI_PROCFS_POWER X86 only
On 2015年05月01日 18:27, Lorenzo Pieralisi wrote:
> The ACPI procfs power interface is initialized by compilation units
> that are only selectable on X86 platforms. Since its usage is
> deprecated and it cannot even be used on platforms other than X86
> it should be compiled in only on X86 platforms.
>
> This patch makes CONFIG_ACPI_PROCFS_POWER dependent on X86, so
> that other architectures are prevented from compiling it in for
> no purpose.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Cc: Lan Tianyu <tianyu.lan@intel.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>

I think this proc fs was not used for IA64 (it is
for server platform) too.

Acked-by: Hanjun Guo <hanjun.guo@linaro.org>

> ---
> Lan, Rafael,
>
> I do not see any reason why this option is allowed to be selected
> on platforms other than X86, so let's make it X86 only. Please let
> me know what you think, thanks.
>
> Lorenzo
>
> drivers/acpi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index ab2cbb5..16da185 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -62,7 +62,7 @@ config ACPI_SLEEP
>
> config ACPI_PROCFS_POWER
> bool "Deprecated power /proc/acpi directories"
> - depends on PROC_FS
> + depends on X86 && PROC_FS
> help
> For backwards compatibility, this option allows
> deprecated power /proc/acpi/ directories to exist, even when
>


\
 
 \ /
  Last update: 2015-05-02 15:41    [W:0.363 / U:21.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site