lkml.org 
[lkml]   [2015]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 55/92] UBI: fix check for "too many bytes"
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Brian Norris <computersforpeace@gmail.com>

    commit 299d0c5b27346a77a0777c993372bf8777d4f2e5 upstream.

    The comparison from the previous line seems to have been erroneously
    (partially) copied-and-pasted onto the next. The second line should be
    checking req.bytes, not req.lnum.

    Coverity CID #139400

    Signed-off-by: Brian Norris <computersforpeace@gmail.com>
    [rw: Fixed comparison]
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/ubi/cdev.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/ubi/cdev.c
    +++ b/drivers/mtd/ubi/cdev.c
    @@ -451,7 +451,7 @@ static long vol_cdev_ioctl(struct file *
    /* Validate the request */
    err = -EINVAL;
    if (req.lnum < 0 || req.lnum >= vol->reserved_pebs ||
    - req.bytes < 0 || req.lnum >= vol->usable_leb_size)
    + req.bytes < 0 || req.bytes > vol->usable_leb_size)
    break;

    err = get_exclusive(desc);



    \
     
     \ /
      Last update: 2015-05-02 22:21    [W:4.264 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site