lkml.org 
[lkml]   [2015]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/4] mtd: sh_flctl: drop unused variable
Date
shdma_tx_submit() called via dmaengine_submit() returns the assigned 
cookie but this is not used here so the variable and assignment can
be dropped.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

V2: As pointed out by Laurent Pinchart <laurent.pinchart@ideasonboard.com>
the variable and assignment can be dropped but not the call to
dmaengine_submit(desc) - fixed up

Patch was compile tested with ap325rxa_defconfig (implies
CONFIG_MTD_NAND_SH_FLCTL=y)

Patch is against 4.1-rc1 (localversion-next is -next-20150501)

drivers/mtd/nand/sh_flctl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index 9b032dd..d1c46e5 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -351,7 +351,6 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf,
struct dma_chan *chan;
enum dma_transfer_direction tr_dir;
dma_addr_t dma_addr;
- dma_cookie_t cookie = -EINVAL;
uint32_t reg;
int ret = 0;
unsigned long time_left;
@@ -377,7 +376,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf,

desc->callback = flctl_dma_complete;
desc->callback_param = flctl;
- cookie = dmaengine_submit(desc);
+ dmaengine_submit(desc);

dma_async_issue_pending(chan);
} else {
--
1.7.10.4


\
 
 \ /
  Last update: 2015-05-02 10:21    [W:0.081 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site