lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] be2net: make hwmon interface optional
From
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 18 May 2015 23:06:45 +0200

> The hwmon interface in the be2net driver causes a link error when
> be2net is built-in while the hwmon subsystem is a loadable module:
>
> drivers/built-in.o: In function `be_probe':
> drivers/net/ethernet/emulex/benet/be_main.c:5761: undefined reference to `devm_hwmon_device_register_with_groups'
>
> This adds a new Kconfig symbol, following the example of multiple
> other drivers that have the same problem. The new CONFIG_BE2NET_HWMON
> will not be available when (BE2NET=y && HWMON=m) to avoid this
> problem.
>
> We have to also mark be_hwmon_show_temp as 'static' to ensure the
> compiler can optimize out all the unused code.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 29e9122b3a ("be2net: Export board temperature using hwmon-sysfs interface.")

Applied, thanks.


\
 
 \ /
  Last update: 2015-05-19 23:21    [W:0.031 / U:5.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site