Messages in this thread | | | Subject | Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable | From | Oliver Neukum <> | Date | Tue, 19 May 2015 19:42:55 +0200 |
| |
On Tue, 2015-05-19 at 19:13 +0200, Takashi Iwai wrote: > At Tue, 19 May 2015 10:26:46 -0400 (EDT), > Alan Stern wrote: > > > > > > > Of just have request_firmware() > > > > > actually sleep until userspace is ready. Seriously, why is > > > > > request_firmware not just sleeping for us. > > > > It won't work. The request_firmware call is part of the probe > > sequence, which in turn is part of the resume sequence. Userspace > > doesn't start running again until the resume sequence is finished. If > > request_firmware waited for userspace, it would hang. > > Note that the recent request_firmware() doesn't need the user-space > invocation (unless the fallback is explicitly enabled) but loads the
That is a dangerous approach. You cannot be sure you can do file IO. It depends on the exact shape of the device tree.
> file directly. And, request_firmware() for the cached data is valid > to be called in the resume path.
Well, yes, if your data is cached in RAM, all is well. But that leads to the same problem one step further. What must be cached?
Regards Oliver
| |