lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] f2fs crypto: add rwsem to avoid data races
On Mon, May 18, 2015 at 10:36:41PM -0700, Jaegeuk Kim wrote:
> Previoulsy, fi->i_crypt_info was not covered by any lock, resulting in
> memory leak.
>
> This patch adds a rwsem to avoid leaking objects on i_crypt_info.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

I'm not sure we need an rwsem to fix this issue. In terms of
serializing the creation and deletion of the structure, it should be
possible to use an cmpxchg() on the pointer itself. (e.g., if we lose
the race on the creation side, we just release our structure and use
the one that the winner allocated).

If we do end up needing to serialize access to the tfm in the
i_crypt_info object for datapath reads/writes, then we might need a
mutex, but I think that should be it, no?

- Ted


\
 
 \ /
  Last update: 2015-05-19 16:41    [W:0.051 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site