lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge
On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf <eng.douglasfigueiredo@gmail.com>

We need a "real" name here, and in the signed-off-by line.

Also fix up your subject line like mentioned.

>
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
>
> Signed-off-by: douglasbsf <eng.douglasfigueiredo@gmail.com>
> ---
> drivers/staging/wlan-ng/prism2fw.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index 9408644..27ead4c 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -708,7 +708,9 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
> continue;
> }
>
> - /* Validate plug address against chunk data and identify chunk */
> + /* Validate plug address against
> + * chunk data and identify chunk
> + */

Please use the correct indentation for multi-line comments as well.

Please fix up and resend, I can't take this as-is.

greg k-h


\
 
 \ /
  Last update: 2015-05-19 16:41    [W:0.056 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site