lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] [RESEND] SCSI: ips: remove pointless #warning
Date
On Tuesday 19 May 2015 06:52:52 James Bottomley wrote:
> On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote:
> > The ips driver contains
> >
> > #warning "This driver has only been tested on the x86/ia64/x86_64 platforms"
> >
> > which gets printed by the compiler every time this driver gets
> > build for something other than those three architectures. The same
> > is true for most other drivers, but none of them prints a warning like
> > this.
> >
> > Let's remove the warning now to reduce the amount of clutter.
> >
> > FWIW, I've reviewed the driver and found a few oddities, but nothing
> > that needs to be fixed or that would be architecture specific.
>
> In principle I don't disagree. However this warning was a specific
> request of the driver writers. Since the driver is pretty much dead,
> I'm not sure anyone is going to check or fix it for non-intel any time
> soon.

My main interest here is to get a clean build of ARM 'allmodconfig'.

If you prefer another approach, we could also add 'depends on X86 || IA64'
into Kconfig, which would also avoid that warning.

Arnd


\
 
 \ /
  Last update: 2015-05-19 16:21    [W:0.040 / U:1.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site