Messages in this thread | | | Date | Tue, 19 May 2015 12:56:31 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v12 8/8] cgroup: implement the PIDs subsystem |
| |
On Tue, May 19, 2015 at 06:44:39PM +1000, Aleksa Sarai wrote: > >> However, it should be noted that organisational operations (adding and > >> removing tasks from a PIDs hierarchy) will *not* be prevented. > > > > This is how you spell: broken controller. > > This has been discussed before. Organisational operations (i.e. > attaching to a cgroup) are not to be blocked by a cgroup controller in > the unified hierarchy.
That's utterly insane. As argued at length in threads like:
lkml.kernel.org/r/alpine.DEB.2.11.1505061100040.4225@nanos
This breaks fundamental control rules and makes life for a number of controllers impossible.
Also, I'll NAK each and every patch that will attempt to remove failing can_attach from the cgroup core as it will fundamentally break some scheduler controllers.
So please use it, it doesn't make any bloody sense to 'control' the number of PIDs but then allow it to overrun the set point.
| |