Messages in this thread | | | Date | Tue, 19 May 2015 15:15:21 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: allow to assign gfp_t for __crypto_alloc_tfm |
| |
On Tue, May 19, 2015 at 12:13:17AM -0700, Jaegeuk Kim wrote: > > The key generation is done by ext4_generate_encryption_key in > fs/ext4/crypto_key.c. > And, ext4_file_mmap and ext4_file_open trigger it.
Well that's where you should be doing crypto_alloc_ablkcipher and crypto_ablkcipher_setkey.
The whole point of a crypto tfm is to represent a key so any time you get one you should create a crypto tfm. Carrying around a raw key is just wrong.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |