lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 13/40] perf tools: Convert dead thread list into rbtree
On Mon, May 18, 2015 at 09:34:25PM +0200, Jiri Olsa wrote:
> On Mon, May 18, 2015 at 09:30:28AM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > @@ -38,6 +39,7 @@ struct thread *thread__new(pid_t pid, pid_t tid)
> > thread->ppid = -1;
> > thread->cpu = -1;
> > INIT_LIST_HEAD(&thread->comm_list);
> > + INIT_LIST_HEAD(&thread->tid_node);
> >
> > if (unwind__prepare_access(thread) < 0)
> > goto err_thread;
> > @@ -54,7 +56,7 @@ struct thread *thread__new(pid_t pid, pid_t tid)
> >
> > list_add(&comm->list, &thread->comm_list);
> > atomic_set(&thread->refcnt, 0);
> > - INIT_LIST_HEAD(&thread->node);
> > + INIT_LIST_HEAD(&thread->tid_node);
>
> tid_node is initialized twice

Okay, will fix.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2015-05-19 09:41    [W:0.153 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site