Messages in this thread | | | Date | Tue, 19 May 2015 18:17:22 -0400 | From | Prarit Bhargava <> | Subject | Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup |
| |
On 05/19/2015 04:31 PM, Borislav Petkov wrote: > On Tue, May 19, 2015 at 01:16:23PM -0700, Andy Lutomirski wrote: >> It's not just chunk size; it's the direction. If the dest starts >> after the source but overlaps it and you copy forwards, then you can >> clobber the end of the source before you read it. memmove is > > Some things should simply be done solely in userspace :-) > >> specifically intended to avoid this. >> >> Would it be possible to just use memmove directly? > > Yeah. > > Prarit, care to send a v2?
Yep, I can do that. It'll have to wait until I get into the office in the morning so I can retest.
P.
> > Thanks. >
| |