lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/6 linux-next] ubifs: remove unnecessary else after break
    On Fri, May 15, 2015 at 11:43:59PM +0200, Fabian Frederick wrote:
    > else is not needed after break in dbg_check_old_index()
    > This also solves the {} parity.
    >
    > Signed-off-by: Fabian Frederick <fabf@skynet.be>
    > ---
    > fs/ubifs/commit.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/fs/ubifs/commit.c b/fs/ubifs/commit.c
    > index 63f5661..dd9ba81 100644
    > --- a/fs/ubifs/commit.c
    > +++ b/fs/ubifs/commit.c
    > @@ -680,9 +680,9 @@ int dbg_check_old_index(struct ubifs_info *c, struct ubifs_zbranch *zroot)
    > if (iip + 1 < le16_to_cpu(idx->child_cnt)) {
    > iip = iip + 1;
    > break;
    > - } else
    > - /* Nope, so go up again */
    > - iip = i->iip;
    > + }
    > + /* Nope, so go up again */
    > + iip = i->iip;
    > }
    > } else
    > /* Go down left */

    I think the 'else' structure makes things clearer, so I'd personally
    just fix the braces. But of course coding style is more opinion than
    science.

    Brian


    \
     
     \ /
      Last update: 2015-05-20 00:21    [W:5.087 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site