lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller
    From
    Date
    Just a nit: a license mismatch.

    On Fri, 2015-05-15 at 20:36 -0700, Aleksey Makarov wrote:
    > --- /dev/null
    > +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c

    > + * This program is free software; you can redistribute it and/or
    > + * modify it under the terms of the GNU General Public License as
    > + * published by the Free Software Foundation; either version 2 of
    > + * the License, or (at your option) any later version.

    This states the license is GPL v2 or later. (The other files used for
    this module contain an identical comment.)

    > +MODULE_LICENSE("GPL v2");

    And, according to include/linux/module.h, this states the license is
    just GPL v2. So I think that either the license used in the comment at
    the top of those files or the ident used in the MODULE_LICENSE() macro
    needs to change.

    Ditto for the thunder_bgx.ko and the nicvf.ko module.

    Thanks,


    Paul Bolle



    \
     
     \ /
      Last update: 2015-05-18 11:21    [W:2.257 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site