Messages in this thread | | | Subject | Re: [PATCH 1/4] modsign: Abort modules_install when signing fails | From | Mimi Zohar <> | Date | Mon, 18 May 2015 21:29:30 -0400 |
| |
On Fri, 2015-05-15 at 17:52 +0100, David Woodhouse wrote: > Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
I assume the patch descriptions will be added before being upstreamed.
> --- > scripts/Makefile.modinst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst > index e48a4e9..07650ee 100644 > --- a/scripts/Makefile.modinst > +++ b/scripts/Makefile.modinst > @@ -22,7 +22,7 @@ quiet_cmd_modules_install = INSTALL $@ > mkdir -p $(2) ; \ > cp $@ $(2) ; \ > $(mod_strip_cmd) $(2)/$(notdir $@) ; \ > - $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) ; \ > + $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) && \ > $(mod_compress_cmd) $(2)/$(notdir $@)
With this patch, as expected the modules_install aborted on failure. Is there any way to capture the reason for the failure? In my case, dropping the '-j <num>' option resolved the problem.
Mimi
> # Modules built outside the kernel source tree go into extra by default
| |