lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: unisys: fix function declaration format in visorchipset.c
On 18-5-2015 12:45, Jes Sorensen wrote:
> Wim de With <nauxuron@wimdewith.com> writes:
>> This is a patch that fixes the function declarations in
>> visorbus/visorchipset.c by removing newlines after the function return
>> type
>
> This patch doesn't fix things, it makes things worse!
>
> If you want to post patches to this, do it properly and check the output
> first.
>
> NACK
>
> Jes

But how is line breaking in function headers supposed to be done? The
coding style documentation specifically state the following:
"Descendants are always substantially shorter than the parent and are
placed substantially to the right. The same applies to function headers
with a long argument list."

I really don't want to bother you with trivial patches, especially when
they are incorrect, but I am trying to learn something, so I hope you
will help me out.

Wim











\
 
 \ /
  Last update: 2015-05-19 02:01    [W:0.041 / U:2.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site