lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v3 00/37] perf tools: introduce 'perf bpf' command to load eBPF programs.
On 5/18/15 1:44 PM, Arnaldo Carvalho de Melo wrote:
>
> perf record --filter, to pass a filter to tracepoints, if I could
> instead of a filter expression pass, say, filter_bpf.o, that would seem
> natural for me, i.e. no new option, just an alternative type of filter,
> one way more powerful.
...
> I'd say keep it in --filter, that noticing it is a bpf object would
> dtrt:
>
> perf record --filter bpf_thing.o usleep 1
>

agree. make sense.
The only thing is that such bpf program defines both event and filter.
Existing --filter applies to --event, whereas this bpf_thing.o does both
and likely kprob-ing multiple events underneath.
I guess '--filter' still fits. Just need to document it clearly.



\
 
 \ /
  Last update: 2015-05-18 23:41    [W:0.412 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site