lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [dm-devel] [PATCH for-4.2 04/14] block: factor out blkdev_issue_discard_async
On Thu, May 14, 2015 at 05:05:02PM -0400, Mike Snitzer wrote:
> From: Joe Thornber <ejt@redhat.com>
>
> Useful for callers who wish to manage the async completion of discard(s)
> without explicitly blocking waiting for completion.
>
> blkdev_issue_discard() is updated to call blkdev_issue_discard_async()
> and DM thinp will make use of blkdev_issue_discard_async() in the
> upcoming "dm thin: range discard support" commit.

I think this is the wrong level of interface. I think dm should just
submit the bios directly, which will also allow it to use bio_chain
properly instead of needing the inc_remaining hack. Instead export
helpers that properly split up the discard chunk sectors without
touching the bio itself. And with bio split on demand work even
that will hopefully go away soon.



\
 
 \ /
  Last update: 2015-05-18 11:01    [W:0.228 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site