Messages in this thread | | | Subject | Re: [PATCH net-next] tcp: Return error instead of partial read for saved syn headers | From | Eric Dumazet <> | Date | Mon, 18 May 2015 12:01:19 -0700 |
| |
On Mon, 2015-05-18 at 11:41 -0700, Rick Jones wrote: > On 05/18/2015 11:35 AM, Eric B Munson wrote: > > Currently the getsockopt() requesting the cached contents of the syn > > packet headers will fail silently if the caller uses a buffer that is > > too small to contain the requested data. Rather than fail silently and > > discard the headers, getsockopt() should return an error and report the > > required size to hold the data. > > Is there any chapter and verse on whether a "failed" getsockopt() may > alter the items passed to it?
This should be fine.
getsockopt() has two copyout to perform, the second one can fail.
We can not 'undo' the first one in a safe way.
| |