lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 4/4] Staging: lustre: sparse lock warning fix
Date
Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' -
'different lock contexts for basic block' by releasing the lock on each
iteration of the for loop.

Signed-off-by: Adrian Remonda <adrianremonda@gmail.com>
---
drivers/staging/lustre/lustre/ptlrpc/nrs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs.c b/drivers/staging/lustre/lustre/ptlrpc/nrs.c
index 43da95f0bce2..3a1722437ca1 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/nrs.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/nrs.c
@@ -503,13 +503,11 @@ static void nrs_resource_put_safe(struct ptlrpc_nrs_resource **resp)

if (nrs == NULL) {
nrs = pols[i]->pol_nrs;
- spin_lock(&nrs->nrs_lock);
}
+ spin_lock(&nrs->nrs_lock);
nrs_policy_put_locked(pols[i]);
- }
-
- if (nrs != NULL)
spin_unlock(&nrs->nrs_lock);
+ }
}

/**
--
2.1.4


\
 
 \ /
  Last update: 2015-05-18 21:21    [W:0.173 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site