Messages in this thread Patch in this message | | | From | Adrian Remonda <> | Subject | [PATCH 4/4] Staging: lustre: sparse lock warning fix | Date | Mon, 18 May 2015 20:34:51 +0200 |
| |
Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' - 'different lock contexts for basic block' by releasing the lock on each iteration of the for loop.
Signed-off-by: Adrian Remonda <adrianremonda@gmail.com> --- drivers/staging/lustre/lustre/ptlrpc/nrs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs.c b/drivers/staging/lustre/lustre/ptlrpc/nrs.c index 43da95f0bce2..3a1722437ca1 100644 --- a/drivers/staging/lustre/lustre/ptlrpc/nrs.c +++ b/drivers/staging/lustre/lustre/ptlrpc/nrs.c @@ -503,13 +503,11 @@ static void nrs_resource_put_safe(struct ptlrpc_nrs_resource **resp) if (nrs == NULL) { nrs = pols[i]->pol_nrs; - spin_lock(&nrs->nrs_lock); } + spin_lock(&nrs->nrs_lock); nrs_policy_put_locked(pols[i]); - } - - if (nrs != NULL) spin_unlock(&nrs->nrs_lock); + } } /** -- 2.1.4
| |