Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver | Date | Mon, 18 May 2015 10:34:08 -0700 |
| |
Noralf Trønnes <noralf@tronnes.org> writes:
> Den 13.05.2015 21:00, skrev Eric Anholt: >> This gives us a function for making mailbox property channel requests >> of the firmware, which is most notable in that it will let us get and >> set clock rates. >> >> Signed-off-by: Eric Anholt <eric@anholt.net> >> --- > > [...] > >> +/* >> + * Submits a single tag to the VPU firmware through the mailbox >> + * property interface. >> + * >> + * This is a convenience wrapper around >> + * rpi_firmware_property_list() to avoid some of the >> + * boilerplate in property calls. >> + */ >> +int rpi_firmware_property(struct device_node *of_node, >> + u32 tag, void *tag_data, size_t buf_size) > > To use the firmware property functions, I need a DT node pointer. > Since Device Tree is dynamic now, should I fetch the firmware node > each time, or should I do that in probe and store the node pointer? > > Device Tree: > firmware: firmware { > compatible = "raspberrypi,firmware"; > }; > > thermal { > compatible = "brcm,bcm2835-thermal"; > firmware = <&firmware>; > };
I'm doing it in probe in my clients -- I don't see why the firmware device's node would change. [unhandled content-type:application/pgp-signature] | |