lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> setup_timer is used for timer parameter setup rather than direct
> assignment
>
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>

your From: name and Signed-off-by: names are not matching. They should
be same.

> ---
<snip>
> --- a/drivers/staging/rtl8192e/rtllib_module.c
> +++ b/drivers/staging/rtl8192e/rtllib_module.c
> @@ -59,9 +59,8 @@ EXPORT_SYMBOL(rt_global_debug_component);
>
> void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
> {
> - ptimer->function = fun;
> - ptimer->data = data;
> init_timer(ptimer);
> + setup_timer(ptimer, fun, data);
setup_timer is calling __setup_timer which is again calling __init_timer
here we already have an init_timer which is also calling __init_timer.
so now __init_timer gets executed two times for one timer.

regards
sudip


\
 
 \ /
  Last update: 2015-05-18 18:21    [W:0.088 / U:1.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site