lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpiolib: debugfs: display gpios requested as irq only
On Mon, May 18, 2015 at 06:17:45PM +0300, Grygorii.Strashko@linaro.org wrote:
> On 05/18/2015 06:08 PM, Johan Hovold wrote:

> > How about instead of
> >
> > GPIOs 160-191, platform/4805d000.gpio, gpio:
> > gpio-171 ((null) ) in hi IRQ209
> >
> > you do something like:
> >
> > GPIOs 160-191, platform/4805d000.gpio, gpio:
> > gpio-171 (<irq-only> ) in hi IRQ-209
>
> In general agree, but i propose to do it as
> GPIOs 160-191, platform/4805d000.gpio, gpio:
> gpio-171 ((null) ) in hi IRQ-209 <irq-only>

I have no strong opinion on whether to use the name-field here or not.

Using the name-field rather than adding a new one could perhaps be
less confusing to current parsers.

> My intention is - this interface could be considered as more or less
> stable, so it is better to add additional information at the end of
> each line to avoid potential breakage of User space SW (test/debug
> scripts).

But if the interface is considered stable (and some people do) you would
not be able to add anything here. This *is* a real issue, but I'll defer
this one to Linus and Alexandre.

Perhaps we should just leave things as they are.

Johan


\
 
 \ /
  Last update: 2015-05-18 18:21    [W:0.074 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site