lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] netfilter: Use correct return for seq_show functions
On Tue, May 12, 2015 at 06:28:23PM -0700, Joe Perches wrote:
> Using seq_has_overflowed doesn't produce the right return value.
> Either 0 or -1 is, but 0 is much more common and works well when
> seq allocation retries.
>
> I believe this doesn't matter as the initial allocation is always
> sufficient, this is just a correctness patch.
>
> Miscellanea:
>
> o Don't use strlen, use *ptr to determine if a string
> should be emitted like all the other tests here
> o Delete unnecessary return statements

Applied, thanks.


\
 
 \ /
  Last update: 2015-05-18 18:21    [W:0.049 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site