Messages in this thread | | | Date | Mon, 18 May 2015 08:51:58 +0200 | From | Michal Kubecek <> | Subject | Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference |
| |
On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote: > This fixes a checkpatch style error in vpfe_buffer_queue_setup. > > Signed-off-by: Alex Dowad <alexinbeijing@gmail.com> > --- > drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c > index 06d48d5..04a687c 100644 > --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c > +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c > @@ -1095,7 +1095,7 @@ vpfe_buffer_queue_setup(struct vb2_queue *vq, const struct v4l2_format *fmt, > size = video->fmt.fmt.pix.sizeimage; > > if (vpfe_dev->video_limit) { > - while (size * *nbuffers > vpfe_dev->video_limit) > + while (size * (*nbuffers) > vpfe_dev->video_limit) > (*nbuffers)--; > } > if (pipe->state == VPFE_PIPELINE_STREAM_CONTINUOUS) {
Style issue aside, is there a reason not to use
if (size * *nbuffers > vpfe_dev->video_limit) *nbuffers = vpfe_dev->video_limit / size;
instead?
Michal Kubecek
| |