Messages in this thread | | | Date | Mon, 18 May 2015 21:57:11 +0800 | Subject | Re: [PATCH v2] clk: mediatek: Initialize clk_init_data | From | Ricky Liang <> |
| |
Hi Sascha,
Sure. I can fix clk-gate.c as well. New patch on the way...
-Ricky
On Mon, May 18, 2015 at 1:54 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > Hi Ricky, > > On Mon, May 18, 2015 at 11:41:49AM +0800, Ricky Liang wrote: >> The variable init (struct clk_init_data) is allocated on the stack. >> We weren't initializing the .flags field, so it contains random junk, >> which can cause all kinds of interesting issues when the flags are >> parsed by clk_register. > > It seems we have the same problem in clk-gate.c aswell. We do initialize > do .flags field there, so this is no urgent problem, but we might get a > real problem when additional fields are added to struct clk_init_data. > Care to fix that aswell along with this patch? > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |