lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v6 1/5] random: Blocking API for accessing nonblocking_pool
    Date
    Am Montag, 18. Mai 2015, 17:21:31 schrieb Herbert Xu:

    Hi Herbert,

    >> +/*
    >> + * Equivalent function to get_random_bytes with the difference that this
    >> + * function blocks the request until the nonblocking_pool is initialized.
    >> + */
    >> +int get_blocking_random_bytes_cb(void *buf, int nbytes, void *private,
    >> + void (*cb)(void *buf, int buflen,
    >> + void *private))
    >
    >You can simplify this further and get rid of buf/nbytes. All
    >we need to know is whether the pool is ready. Everything else
    >can come from private.
    >
    So, the async function is now just a notification of the caller. Sounds good
    with me.

    >> + struct random_work *rw = NULL;
    >> + int ret = 0;
    >
    >I think this function should return 0 if the pool is ready now,
    >-EINPROGRESS if it's not (indicating that the callback will be
    >called when it is ready) and otherwise an error.

    Ok, will come in the next patch.

    Ciao
    Stephan


    \
     
     \ /
      Last update: 2015-05-18 15:21    [W:3.463 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site