Messages in this thread | | | Date | Mon, 18 May 2015 13:02:14 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only |
| |
On Fri, May 15, 2015 at 04:25:21PM +0300, grygorii.strashko@linaro.org wrote: > From: Grygorii Strashko <grygorii.strashko@linaro.org> > > Now GPIOs, wich are requested as IRQ only, will not be displayed > through GPIO debugfs. For example: > # cat /proc/interrupts > CPU0 CPU1 > ... > 209: 0 0 4805d000.gpio 11 Edge 0-0021 > > # cat /debug/gpio > ... > GPIOs 160-191, platform/4805d000.gpio, gpio: > <--- no info about gpio used as IRQ only here > > GPIOs 192-223, platform/48051000.gpio, gpio: > gpio-203 (vtt_fixed ) out hi > ... > > Hence, improve GPIO debugfs code to show such kind of gpio and print > IRQ number also. In addition, add marker "requested" for GPIOs wich > were requested by using gpioX_request(). > > After this patch sys/kernel/debug/gpio will produce following output: > > # cat /debug/gpio > ... > GPIOs 160-191, platform/4805d000.gpio, gpio: > gpio-171 ((null) ) in hi IRQ209 > > GPIOs 192-223, platform/48051000.gpio, gpio: > gpio-203 (vtt_fixed ) out hi requested
This is backwards. All gpios *should* be requested. *If* we are to include not-requested gpios in the debug output, then it is those pins that need to be marked as not-requested.
The irq-number mapping could perhaps be useful, but it should go in a separate patch. I'd suggest adding a '-' before the irq-number (e.g. "IRQ-209").
Thanks, Johan
| |