Messages in this thread | | | Date | Mon, 18 May 2015 11:40:43 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 1/2] ARM: simplify timer initialisation and remove arm_timer.h inclusion |
| |
On Thu, Apr 30, 2015 at 09:09:47AM -0500, Rob Herring wrote: > On Thu, Apr 30, 2015 at 5:44 AM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > The header asm/hardware/arm_timer.h is included in various machine > > specific files to access TIMER_CTRL and initialise to a known state. > > However that's not required as the clock{source,event} driver timer-sp > > initialises all the timer being used. > > I believe the idea is not to initialize the timers being used, but the > ones not being used and perhaps left running by the bootloader. Cases > where the interrupt is shared could cause a problem.
Exactly. IMHO this code needs to stay.
-- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
| |