Messages in this thread | | | Date | Mon, 18 May 2015 15:09:57 +1000 | From | Anton Blanchard <> | Subject | Re: [PATCH V3 09/13] selftests, powerpc: Add test for DSCR value inheritence across fork |
| |
Hi Anshuman,
Thanks for getting these testcases into the kernel.
> This patch adds a test to verify that the changed DSCR value inside > any process would be inherited to it's child process across the fork > system call.
One issue I do notice (a bug in my original test cases too), is that we don't restore the DSCR on exit. I'm not sure we need to go to the trouble of saving and restoring it, but we should at least get it back to 0 when done.
Also a tiny nit, no need for a newline in perror():
open() failed : Permission denied
With those changes you can add:
Signed-off-by: Anton Blanchard <anton@samba.org>
to the patches based on my testcases.
Anton
| |