Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 1/1] power: validate wakeup source before activating it. | Date | Mon, 18 May 2015 02:34 +0200 |
| |
On Friday, May 15, 2015 06:28:17 PM Jin Qian wrote: > Hi Rafael, > > The latest version is in [PATCHv3 1/3] power: validate wakeup source > before activating it. I changed WARN_ONCE back to WARN since if > multiple drivers activating uninitialized wakeup_sources, only the > first driver will by flagged.
Which is OK.
If you're a user, you can't fix the problem by yourself and spamming the logs with continued warnings doesn't help here.
If you're a developer, you'll fix the first driver and then see the warning from the second one.
> We lost alert for other drivers. The warning should really happen during > driver development. Hope this is ok.
First, I've applied your patch already. Second, I really think that WARN_ON_ONCE() is better here.
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |