Messages in this thread | | | From | Leon Romanovsky <> | Date | Sat, 16 May 2015 21:56:52 +0300 | Subject | Re: [RFC] Refactor kenter/kleave/kdebug macros |
| |
On Sat, May 16, 2015 at 8:09 PM, Joe Perches <joe@perches.com> wrote: > On Sat, 2015-05-16 at 20:01 +0300, Leon Romanovsky wrote: [] >> My question is how we should handle such duplicated debug print code? >> As possible solutions, I see five options: >> 1. Leave it as is. >> 2. Move it to general include file (for example linux/printk.h) and >> commonize the output to be consistent between different kdebug users. >> 3. Add CONFIG_*_DEBUG definition for every kdebug user. >> 4. Move everything to "#if 0" construction. >> 5. Move everything to "#if defined(__KDEBUG)" construction. > > 6: delete the macros and uses Thank you, It is indeed possible option, since in last six years there were no attempts to "open" this code.
-- Leon Romanovsky | Independent Linux Consultant www.leon.nu | leon@leon.nu
| |