lkml.org 
[lkml]   [2015]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 001/142] ip_forward: Drop frames with attached skb->sk
    Date
    From: Sebastian Pöhn <sebastian.poehn@gmail.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    [ Upstream commit 2ab957492d13bb819400ac29ae55911d50a82a13 ]

    Initial discussion was:
    [FYI] xfrm: Don't lookup sk_policy for timewait sockets

    Forwarded frames should not have a socket attached. Especially
    tw sockets will lead to panics later-on in the stack.

    This was observed with TPROXY assigning a tw socket and broken
    policy routing (misconfigured). As a result frame enters
    forwarding path instead of input. We cannot solve this in
    TPROXY as it cannot know that policy routing is broken.

    v2:
    Remove useless comment

    Signed-off-by: Sebastian Poehn <sebastian.poehn@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    net/ipv4/ip_forward.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c
    index 31ee5c6033df..479e8a63125a 100644
    --- a/net/ipv4/ip_forward.c
    +++ b/net/ipv4/ip_forward.c
    @@ -126,6 +126,9 @@ int ip_forward(struct sk_buff *skb)
    struct rtable *rt; /* Route we use */
    struct ip_options *opt = &(IPCB(skb)->opt);

    + if (unlikely(skb->sk))
    + goto drop;
    +
    if (skb_warn_if_lro(skb))
    goto drop;

    --
    2.3.7


    \
     
     \ /
      Last update: 2015-05-16 11:21    [W:2.588 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site