lkml.org 
[lkml]   [2015]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 045/142] arm64: vdso: fix build error when switching from LE to BE
    Date
    From: Arun Chandran <achandran@mvista.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 1915e2ad1cf548217c963121e4076b3d44dd0169 upstream.

    Building a kernel with CPU_BIG_ENDIAN fails if there are stale objects
    from a !CPU_BIG_ENDIAN build. Due to a missing FORCE prerequisite on an
    if_changed rule in the VDSO Makefile, we attempt to link a stale LE
    object into the new BE kernel.

    According to Documentation/kbuild/makefiles.txt, FORCE is required for
    if_changed rules and forgetting it is a common mistake, so fix it by
    'Forcing' the build of vdso. This patch fixes build errors like these:

    arch/arm64/kernel/vdso/note.o: compiled for a little endian system and target is big endian
    failed to merge target specific data of file arch/arm64/kernel/vdso/note.o

    arch/arm64/kernel/vdso/sigreturn.o: compiled for a little endian system and target is big endian
    failed to merge target specific data of file arch/arm64/kernel/vdso/sigreturn.o

    Tested-by: Mark Rutland <mark.rutland@arm.com>
    Signed-off-by: Arun Chandran <achandran@mvista.com>
    Signed-off-by: Will Deacon <will.deacon@arm.com>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    arch/arm64/kernel/vdso/Makefile | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile
    index 6d20b7d162d8..a268a9af0c2d 100644
    --- a/arch/arm64/kernel/vdso/Makefile
    +++ b/arch/arm64/kernel/vdso/Makefile
    @@ -43,7 +43,7 @@ $(obj)/vdso-offsets.h: $(obj)/vdso.so.dbg FORCE
    $(call if_changed,vdsosym)

    # Assembly rules for the .S files
    -$(obj-vdso): %.o: %.S
    +$(obj-vdso): %.o: %.S FORCE
    $(call if_changed_dep,vdsoas)

    # Actual build commands
    --
    2.3.7


    \
     
     \ /
      Last update: 2015-05-16 10:41    [W:4.093 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site