lkml.org 
[lkml]   [2015]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Open-FCoE] [PATCH] scsi: fix Wunused-but-set-variable buildwarning
On Thu, 14 May 2015, Prasad Gondi wrote:

> It seems like rpriv is used to set the fsp->tgt_flags originally
>
> > fsp->tgt_flags = rpriv->flags
>
> And fsp->tgt_flags are used in "fc_fcp_cmd_send" like this
>
> setup_timer(&fsp->timer, fc_fcp_timeout, (unsigned long)fsp);
> if (rpriv->flags & FC_RP_FLAGS_REC_SUPPORTED)
> fc_fcp_timer_set(fsp, get_fsp_rec_tov(fsp));
>
> Main purpose of this flags used is to set the correct TimeOut Value for fc_fcp_timer.
>
> So is the removal of the "fsp->tgt_flags = rpriv->flags" in fc_queuecommand() is intentional? Or by mistake?
>
thats something I can't say - but the commit message indicated that the
removal of tgt_flags was intentional.

> Once we clear that out we can see whether this change make sense?
>
yup - many thanks !

hofrat



\
 
 \ /
  Last update: 2015-05-15 09:21    [W:0.050 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site