lkml.org 
[lkml]   [2015]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] x86, espfix: use spin_lock rather than mutex

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 05/14/2015 02:27 PM, Borislav Petkov wrote:
> > Remove stable@ from CC.
> >
> > On Thu, May 14, 2015 at 08:29:55PM +0200, Ingo Molnar wrote:
> >> We could allocate them on the boot CPU side and hand them over to
> >> the secondary CPU.
> >
> > Yeah, something along those lines. I mean, they're allocated and
> > in-use during the complete system lifetime, we might just as well
> > allocate them all in one go. Btw, what's our allocator that early,
> > memblock?
> >
> > Still, what I find strange is why are we seeing this only now? Is
> > it because it had to be a big box (cpu >= 128) or something else
> > changed...?
> >
>
> Quite probable. You don't really want to allocate them until you
> know if a CPU at least exists, though.
>
> I like Ingo's suggestion of allocating them before CPU bringup on
> the initiating CPU.

The only slightly subtle detail with that is to use alloc_pages_node()
with the secondary CPU's node, to make sure the espfix stack is
NUMA-local to the CPU that is going to use it.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-05-15 09:21    [W:0.102 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site