lkml.org 
[lkml]   [2015]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] mmc: omap_hsmmc: Add support for slot-name property in DT
    Date
    On Friday 15 May 2015 23:19:44 Arnd Bergmann wrote:
    > On Friday 15 May 2015 23:14:48 Pali Rohár wrote:
    > > diff --git a/drivers/mmc/host/omap_hsmmc.c
    > > b/drivers/mmc/host/omap_hsmmc.c index 9df2b68..f6073dd 100644
    > > --- a/drivers/mmc/host/omap_hsmmc.c
    > > +++ b/drivers/mmc/host/omap_hsmmc.c
    > > @@ -1901,6 +1901,8 @@ static struct omap_hsmmc_platform_data
    > > *of_get_hsmmc_pdata(struct device *dev)
    > >
    > > if (of_find_property(np, "ti,needs-special-hs-handling",
    > > NULL))
    > >
    > > pdata->features |= HSMMC_HAS_HSPE_SUPPORT;
    > >
    > > + of_property_read_string(np, "slot-name", &pdata->name);
    > > +
    > >
    > > return pdata;
    > >
    > > }
    >
    > This property needs to be documented in
    > Documentation/devicetree/bindings/mmc/mmc.txt and preferably the
    > implementation moved into mmc_of_parse.
    >
    > We should not have an interface like this specific to one driver.
    >
    > Arnd

    Interface is already present for platform data code (which do not use
    DT). So "pdata->name" is not DT specific...

    --
    Pali Rohár
    pali.rohar@gmail.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2015-05-15 23:41    [W:3.337 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site