Messages in this thread | | | Date | Fri, 15 May 2015 19:41:56 +0200 | From | Michal Kubecek <> | Subject | Re: [PATCH net v2 2/2] ipv6: fix ECMP route replacement |
| |
On Fri, May 15, 2015 at 12:12:12PM -0400, David Miller wrote: > From: Michal Kubecek <mkubecek@suse.cz> > Date: Fri, 15 May 2015 10:51:52 +0200 > > > But I still rather feel like replacing all existing matching routes > > would better reflect what I expect "replace" to do. > > What does IPV4 do?
Apparently there is some problem too as on 4.1-rc3, "ip route replace" seems to always remove first matching IPv4 route (multipath or not) but doesn't add the new one unless there was no matching route before calling the command (then it behaves like "add").
I also tried 3.0 and it replaces first matching route, whether it was multipath or not and whether the new one is multipath or not. This behaviour cannot be directly transfered to IPv6 as there are no real IPv6 multipath routes; instead, the set of all routes under a node with the same metric satisfying rt6_qualify_for_ecmp() is handled as a multipath route (so that there can be only one). The semantics I suggested in my previous mail might be a reasonable approximation.
Michal Kubecek
| |