Messages in this thread | | | Date | Fri, 15 May 2015 13:14:00 +0200 | From | Roger Pau Monné <> | Subject | Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place |
| |
El 15/05/15 a les 13.03, Bob Liu ha escrit: > > On 05/15/2015 06:01 PM, Roger Pau Monné wrote: >> El 12/05/15 a les 13.01, Bob Liu ha escrit: >>> The right place for talk_to_blkback() to query backend features and transport >>> parameters is after backend entered XenbusStateInitWait. There is no problem >> >> talk_to_blkback doesn't gather any backend features, it just publishes >> the features supported by the frontend, which AFAICT can be done at any > > 1) But talk_tlkback will also allocate and initialize the request ring which > should be done after backend entered XenbusStateInitWait.
Maybe setup_blkring should be moved to a more suitable location instead of moving the whole function?
Roger.
| |