Messages in this thread | | | Date | Fri, 15 May 2015 15:46:49 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] staging: rts5208: remove always true comparison |
| |
On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote: > On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote: > > the if comparison is always true as anything bitwise and-ing with 0x1E > > can never be equal to 0x03. > > > > Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881 > > > > It doesn't fix anything though, it just silences the warning. Warnings > are nice because they let you know that the code is buggy. It's better > to leave them there instead of making the bugs more complicated to find.
but I am not seeing any warnings. I tried with make W=1, tried with sparse, but still no warning. am i missing something?
regards sudip
| |