Messages in this thread | | | Date | Thu, 14 May 2015 14:43:14 -0700 | From | Florian Fainelli <> | Subject | Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver. |
| |
On 14/05/15 13:12, Mark Brown wrote: > On Thu, May 14, 2015 at 12:55:32PM -0700, Jonathan Richardson wrote: >> On 15-05-14 12:08 PM, Mark Brown wrote: > >>> All it takes is one hardware engineer who sees a SPI controller and a >>> GPIO they can use for chip select; I wouldn't be so sure that nobody >>> ever fixed this up locally (or happened to use a device that only needed >>> single duplex). > >> Hi Mark. Would it help if we just set the flags to half duplex using >> SPI_MASTER_HALF_DUPLEX when we register the master? > > That would deal with the data corruption issues, yes. Though it seems > like there are some people who want full duplex support here - I don't > know if any of them can point you at suitable hardware to test?
I am fine with having the driver supporting only half-duplex for now, considering that Jonathan and Scott have no peripheral to test full-duplex with.
Getting you platforms and test setups could take more time than needed so, let's proceed with the shortest path. -- Florian
| |