Messages in this thread Patch in this message | | | Date | Thu, 14 May 2015 15:33:36 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins |
| |
On Tue, May 12, 2015 at 06:41:56AM +0000, He Kuang wrote:
SNIP
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 03409cc..338c426 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -172,6 +172,7 @@ endif > > LIBTRACEEVENT = $(TE_PATH)libtraceevent.a > export LIBTRACEEVENT > +LIBTRACEEVENT_DYNAMIC_LIST = $(TE_PATH)libtraceevent-dynamic-list > > LIBAPI = $(LIB_PATH)libapi.a > export LIBAPI > @@ -278,8 +279,9 @@ build := -f $(srctree)/tools/build/Makefile.build dir=. obj > $(PERF_IN): $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h FORCE > $(Q)$(MAKE) $(build)=perf > > -$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) > - $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(PERF_IN) $(LIBS) -o $@ > +LD_LIBTRACEEVENT_FLAGS += -Xlinker --dynamic-list=$(LIBTRACEEVENT_DYNAMIC_LIST)
Could you please just update LDFLAGS directly? I dont think there's a need for separated variable..
otherwise it seems ok to me
thanks, jirka
| |